Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync ss sql parser #302

Closed
wants to merge 4 commits into from
Closed

sync ss sql parser #302

wants to merge 4 commits into from

Conversation

tuohai666
Copy link
Member

For #168

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #302 (5d14d3f) into master (3a04fb0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #302   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         365     365           
  Lines        6861    6861           
  Branches     1208    1208           
======================================
  Misses       6861    6861           
Impacted Files Coverage Δ
.../shardingsphere/ShardingSphereSqlParserEngine.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a04fb0...5d14d3f. Read the comment docs.

Copy link
Contributor

@cherrylzhao cherrylzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the modified code, hmily will only support mysql syntax?

@tuohai666 tuohai666 closed this May 21, 2021
@tuohai666
Copy link
Member Author

from the modified code, hmily will only support mysql syntax?

Do you mean PostgreSQL? I'll think about it.

@cherrylzhao
Copy link
Contributor

yes it is, since shardingsphere support other rdb parsers

@tuohai666 tuohai666 deleted the 168 branch May 21, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants