Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PhotoSwipe v5 #591

Closed
3 tasks done
irudoy opened this issue Aug 3, 2021 · 2 comments · Fixed by #592
Closed
3 tasks done

Support PhotoSwipe v5 #591

irudoy opened this issue Aug 3, 2021 · 2 comments · Fixed by #592
Milestone

Comments

@irudoy
Copy link
Contributor

irudoy commented Aug 3, 2021

Preparing to forthcoming PhotoSwipe v5 release dimsemenov/PhotoSwipe#1749.
It was fully rewritten and some initialization-relative concepts have changed.

  • react-photoswipe-gallery v2.x should get rid of CustomGallery and support only PhotoSwipe >=v5
  • react-photoswipe-gallery v1.x will support PhotoSwipe <=v4

What should be done:

  • add new props for Item component (cropped, srcset, etc.)
  • decide what to do with removed features like HistoryAPI/captions
  • implement PhotoSwipeLightbox functionality (pointerPos, global check, destroy on unmount)
@irudoy irudoy added this to the v2.0.0 milestone Aug 5, 2021
@irudoy irudoy linked a pull request Aug 5, 2021 that will close this issue
18 tasks
@Perni1984
Copy link

@irudoy we are planning to use PhotoSwipe v5 in our next.js based website. Is the v5 branch already usable, or can we contribute here to get it useable?

@irudoy
Copy link
Contributor Author

irudoy commented Dec 13, 2021

@Perni1984 I would not recommend using v5 in production while dimsemenov/PhotoSwipe v5 is in the beta stage. dromru/react-photoswipe-gallery/tree/photoswipe-v5 is definitely not ready yet, even though it works in general. Anyway, you can give it a try with yarn add photoswipe@dimsemenov/photoswipe#v5-beta react-photoswipe-gallery@next, if you like adventures :) But API definitely will change slightly.

@irudoy irudoy changed the title PhotoSwipe v5 Support PhotoSwipe v5 Apr 1, 2022
@irudoy irudoy pinned this issue Apr 6, 2022
@irudoy irudoy unpinned this issue Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants