Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhotoSwipe v5 #592

Merged
merged 50 commits into from
Apr 15, 2022
Merged

PhotoSwipe v5 #592

merged 50 commits into from
Apr 15, 2022

Conversation

irudoy
Copy link
Contributor

@irudoy irudoy commented Aug 3, 2021

add new props for Item component (cropped, srcset, etc.)

  • add Item.thumbCropped
  • add Item.originalSrcset
  • add Item.alt
  • investigate missed options

implement PhotoSwipeLightbox functionality (pointerPos, global check, destroy on unmount)

misc

  • use vendor PhotoSwipe typings (moving to backlog)
  • default captions via caption prop
  • History API
  • custom buttons https://photoswipe.com/v5/docs/adding-custom-buttons/
  • investigate missed features
  • test react 18 (waiting for storybook support)
  • plugins (support of existing / implement at wrapper level)

pre-release chores

  • improve test coverage
  • write full changelog
  • double check readme

@irudoy irudoy self-assigned this Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #592 (b847e0a) into master (bba0ec6) will increase coverage by 2.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
+ Coverage   95.76%   98.13%   +2.36%     
==========================================
  Files          10       14       +4     
  Lines         189      214      +25     
  Branches       38       38              
==========================================
+ Hits          181      210      +29     
+ Misses          8        4       -4     
Impacted Files Coverage Δ
src/no-ref-error.ts 100.00% <ø> (ø)
src/gallery.tsx 100.00% <100.00%> (ø)
src/helpers/get-base-url.ts 100.00% <100.00%> (ø)
src/helpers/get-hash-value.ts 100.00% <100.00%> (ø)
src/helpers/get-hash-without-gid-and-pid.ts 100.00% <100.00%> (ø)
src/helpers/hash-to-object.ts 100.00% <100.00%> (ø)
src/helpers/object-to-hash.ts 100.00% <100.00%> (ø)
src/helpers/shuffle.ts 100.00% <100.00%> (ø)
src/helpers/sort-nodes.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba0ec6...b847e0a. Read the comment docs.

@irudoy irudoy marked this pull request as draft August 3, 2021 11:53
@irudoy irudoy linked an issue Aug 5, 2021 that may be closed by this pull request
3 tasks
@irudoy irudoy added this to the v2.0.0 milestone Aug 5, 2021
@irudoy irudoy marked this pull request as ready for review August 6, 2021 04:08
@irudoy irudoy marked this pull request as draft August 6, 2021 04:08
akhmadullin and others added 26 commits April 15, 2022 18:37
update changelog; fix readme; withDefaultGallery -> withGallery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PhotoSwipe v5
2 participants