Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-9739 - workload identity/OIDC support for GAR/GCR #413

Merged
merged 2 commits into from
Oct 23, 2023
Merged

ci-9739 - workload identity/OIDC support for GAR/GCR #413

merged 2 commits into from
Oct 23, 2023

Conversation

eoinmcafee00
Copy link
Contributor

No description provided.

@eoinmcafee00 eoinmcafee00 requested review from raghavharness and removed request for tphoney and raghavharness October 20, 2023 13:42
@eoinmcafee00 eoinmcafee00 merged commit 757a756 into master Oct 23, 2023
1 check passed
@eoinmcafee00 eoinmcafee00 deleted the ci-9739 branch October 23, 2023 09:11
@bradrydzewski
Copy link
Member

@eoinmcafee00 I would recommend splitting gcr and gar into two separate docker images (add cmd/drone-gar). The reason is that they are two separate products. For this reason, when an end-user searches for "gar" in the marketplace it may not be intuitive that they should use "gcr" with "gar" as the type

@eoinmcafee00
Copy link
Contributor Author

Hey @bradrydzewski
PR for this: #415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vistaarjuneja vistaarjuneja vistaarjuneja approved these changes

@raghavharness raghavharness raghavharness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eoinmcafee00 @bradrydzewski @vistaarjuneja @raghavharness