Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Consider all release types #69

Merged
merged 1 commit into from Nov 25, 2020
Merged

[Feature] Consider all release types #69

merged 1 commit into from Nov 25, 2020

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Nov 23, 2020 •
edited

Follow-Up on #68 (fixes #65) including fix for issue #71 as per comments below.

@iwilltry42 iwilltry42 mentioned this pull request Nov 23, 2020
Merged
@lafriks
Copy link

lafriks commented Nov 23, 2020

As #68 was reverted this needs new start taking into account issue #71

lafriks
lafriks suggested changes Nov 23, 2020
View reviewed changes
Copy link

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my previous comment :)

@iwilltry42 iwilltry42 force-pushed the feature/publish-drafted-release branch from a3b9e10 to 2963df0 Compare November 23, 2020 19:15
@iwilltry42 iwilltry42 changed the title [Fix] always publish drafts (not only if overwrite=true) [Feature] Consider all release types Nov 23, 2020
@iwilltry42
Copy link
Contributor Author

iwilltry42 commented Nov 23, 2020 •
edited

@lafriks I pulled the original changes into this PR and rewrote it.
The error came from leftover, but now improper case handling, when no release was returned, but also no error was raised. It should be fixed now. Please give it a try.
(Relevant Lines: https://github.com/drone-plugins/drone-github-release/pull/69/files#diff-d839f0f9a2a680ce257706a246a02fc0a8ef3eb09212ae1d5085fa84c7dc7321R36-R49)

Side note: CI is failing because it's hitting DockerHub's new awesome pull rate limit 😖

toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

@tboerger
Copy link
Contributor

@bradrydzewski could you just configure a pull-through cache for cloud.drone.io?

@lafriks lafriks added the enhancement New feature or request label Nov 24, 2020
@donny-dont
Copy link
Contributor

@Upgreydd could you please take a look at this to make sure it works since you reported that failure?

@bradrydzewski
Copy link
Member

bradrydzewski commented Nov 25, 2020 •
edited

the step that executes a dry run docker build needs to be removed because this results in unauthenticated pulls to dockerhub, which will hit dockerhub rate limits frequently going forward.

@donny-dont
Copy link
Contributor

@bradrydzewski the dry-run step is removed in #72

@donny-dont
Copy link
Contributor

@iwilltry42 if you rebase the build should complete

@iwilltry42
feature: consider every type of release (real, pre, draft)
0bddbde 
- loop through list of releases to find one associated with the tag
- convert drafted releases to published releases (no downgrading)
@iwilltry42 iwilltry42 force-pushed the feature/publish-drafted-release branch from 2963df0 to 0bddbde Compare November 25, 2020 19:12
@iwilltry42
Copy link
Contributor Author

@donny-dont ✔️

@donny-dont donny-dont merged commit f00f91d into drone-plugins:master Nov 25, 2020
@iwilltry42 iwilltry42 deleted the feature/publish-drafted-release branch November 26, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish a drafted release
5 participants
@iwilltry42 @lafriks @tboerger @donny-dont @bradrydzewski