Remove standard http ports from registry URL when writing authToken #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of this plugin included an update of the NPM client from v6 to v8, which changed the authentication behaviour of the client.
If a private registry URL contains standard http port 80 or 443 when performing an
npm login / adduser
command the port number is removed when writing the authToken to the .npmrc file. If the port remains in the authToken registry URL then the token is ignored when running commands likenpm whoami
ornpm publish
and results in an error asking to runnpm adduser
.Because this plugin writes the .npmrc file directly we need to remove the port from the registry URL before writing.
Example:
Invalid
.npmrc
authTokenValid
.npmrc
authToken