Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a host alias for detached steps #52

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Add a host alias for detached steps #52

merged 1 commit into from
Jul 27, 2021

Conversation

hhomar
Copy link
Contributor

@hhomar hhomar commented Mar 27, 2021

This allows detached steps to be referenced by other steps as per
services.

This allows detached steps to be referenced by other steps as per
services.
@marko-gacesa
Copy link
Contributor

marko-gacesa commented Jul 13, 2021

@hhomar what was the concrete example you needed this for? How would a user, use this ?

@bradrydzewski
Copy link
Collaborator

@marko-gacesa I think I understand this pull request. Currently we have the ability to define services and then communicate with those services using a hostname: https://docs.drone.io/pipeline/kubernetes/syntax/services/

this pull request look like it ensures this works for detached servers (services defined in the steps section). See https://docs.drone.io/pipeline/kubernetes/syntax/services/#detached-steps

@hhomar
Copy link
Contributor Author

hhomar commented Jul 13, 2021

Hi. Sorry, I should have been more clear in the pull request, but you're exactly right.

This was how it worked when I was using the docker pipeline.

@mshebeko-twist
Copy link

mshebeko-twist commented Jul 25, 2021

Hi, do we have an estimate of this PR being merged?
Pipelines that worked with docker pipelines stopped working for me.

Another thing is - it's maybe easier to propagate step name to container name inside pod, this way kubernetes will know how to route packets between containers, and it will be much easier to debug pipeline from kubernetes as pod-name = step-name.

@tphoney tphoney merged commit e36f39b into drone-runners:master Jul 27, 2021
@tphoney
Copy link

tphoney commented Jul 27, 2021

thanks for the work @hhomar

@tphoney tphoney added the enhancement New feature or request label Aug 16, 2021
@hhomar hhomar deleted the use-host-alias-for-detached-steps branch November 12, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants