Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more attributes to local build context #175

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Sep 30, 2020

Description

When using drone starlark locally, some of the context attributes which are available on drone server are missing

Added

  • build.source_repo
  • build.title
./drone starlark -h
NAME:
   drone starlark - generate .drone.yml from starlark

USAGE:
   drone starlark [command options] [path/to/.drone.star]

OPTIONS:
   --source value             Source file (default: ".drone.star")
   --target value             target file (default: ".drone.yml")
   --format                   Write output as formatted YAML
   --stdout                   Write output to stdout
   --repo.name value          repository name
   --repo.namespace value     repository namespace
   --repo.slug value          repository slug
   --build.event value        build event (default: "push")
   --build.branch value       build branch (default: "master")
   --build.source value       build source branch (default: "master")
   --build.source_repo value  repo slug of source repository
   --build.target value       build target branch (default: "master")
   --build.ref value          build ref (default: "refs/heads/master")
   --build.commit value       build commit sha
   --build.message value      build commit message
   --build.title value        build title

@micbar
Copy link
Contributor Author

micbar commented Sep 30, 2020

@tboerger @bradrydzewski

This addition makes it possible to convert complex starlark files into .yml

@tboerger
Copy link
Contributor

tboerger commented Oct 8, 2020

@bradrydzewski WDYT?

@dschmidt
Copy link
Contributor

@bradrydzewski ping?

@micbar
Copy link
Contributor Author

micbar commented Nov 17, 2020

@bradrydzewski @tboerger I rebased it.

Would be handy to get this merged.

@phil-davis
Copy link
Contributor

@bradrydzewski please review and give your comments...

@bradrydzewski bradrydzewski merged commit 3ba95af into harness:master Dec 4, 2020
@phil-davis
Copy link
Contributor

@bradrydzewski any chance for a release "soon"?

It would be nice to be able to use this change in a real release.

@phil-davis
Copy link
Contributor

@bradrydzewski ping again - any chance for a release?

@phil-davis phil-davis mentioned this pull request Jan 21, 2021
@phil-davis
Copy link
Contributor

@bradrydzewski can you just take a few minutes to make a release with whatever code is in master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants