Add retries option
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be enabled this way: ``` clone: retries: 3 ```
tphoney
approved these changes
Nov 9, 2021
julienduchesne
force-pushed
the
retries
branch
from
e77bae3
to
f2de155
Compare
julienduchesne
force-pushed
the
retries
branch
from
28338a9
to
fd44ec6
Compare
|
Hi @julienduchesne this seems sensible, how where you going to pass the env var in from the runners ? |
I'd like to add a Currently, we are using this as a custom clone step |
julienduchesne
added a commit
to julienduchesne/runner-go
that referenced
this pull request
Nov 23, 2021
Will be used to support drone/drone-git#43
julienduchesne
added a commit
to grafana/drone-runner-docker
that referenced
this pull request
Nov 23, 2021
Used to support drone/drone-git#43 Will require a go mod update to add the arg to the manifest: drone/runner-go#22
|
Thanks for the merge @tphoney. I also created these two PRs to expose the option: |
tphoney
pushed a commit
to drone-runners/drone-runner-docker
that referenced
this pull request
Jun 9, 2022
* Add retries option to the clone step Used to support drone/drone-git#43 Will require a go mod update to add the arg to the manifest: drone/runner-go#22 * Update `runner-go` to v1.12.0 * Add test
julienduchesne
added a commit
to julienduchesne/docs-1
that referenced
this pull request
Aug 2, 2022
Tested on our pipelines Implemented in drone/drone-git#43 + drone-runners/drone-runner-docker#44 + drone/runner-go#22
|
@julienduchesne what's the delay between retries? should sleep for 5 or 10 seconds right? Otherwise, all retries happen very quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the
PLUGIN_VARformat in order to allow enabling it this way:Updated from #27