New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #115: fix build duration #116

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mavimo
Contributor

mavimo commented May 18, 2017

Fix build duration visibility (see issue)

cc/ @bradrydzewski

@bradrydzewski

This comment has been minimized.

Show comment
Hide comment
@bradrydzewski

bradrydzewski May 19, 2017

Member

Thanks, this is definitely a bug, but I think we need to analyze this more. It looks like the timestamp and duration are both incorrect. See this screenshot from 0.5 when it was last working:

image

The top value should display the timestamp and bottom value should display the duration.

Right now it looks like the top value is always blank with a -- and the bottom value displays the timestamp.

Member

bradrydzewski commented May 19, 2017

Thanks, this is definitely a bug, but I think we need to analyze this more. It looks like the timestamp and duration are both incorrect. See this screenshot from 0.5 when it was last working:

image

The top value should display the timestamp and bottom value should display the duration.

Right now it looks like the top value is always blank with a -- and the bottom value displays the timestamp.

@mavimo

This comment has been minimized.

Show comment
Hide comment
@mavimo

mavimo May 20, 2017

Contributor

Opps, i supposed to display duration and timestamp, I'm going to fix it.

Contributor

mavimo commented May 20, 2017

Opps, i supposed to display duration and timestamp, I'm going to fix it.

@mavimo

This comment has been minimized.

Show comment
Hide comment
@mavimo

mavimo May 20, 2017

Contributor
Contributor

mavimo commented May 20, 2017

@bradrydzewski

This comment has been minimized.

Show comment
Hide comment
@bradrydzewski

bradrydzewski May 22, 2017

Member

This ended up being a bit more complex since the fix also needed to take matrix build status into account. I ended up patching locally and pushing.

Thanks for locating this issue though. I was able to build on your patch to get this fixed!

Member

bradrydzewski commented May 22, 2017

This ended up being a bit more complex since the fix also needed to take matrix build status into account. I ended up patching locally and pushing.

Thanks for locating this issue though. I was able to build on your patch to get this fixed!

@mavimo mavimo deleted the mavimo:feature/115-fix-build-duration branch Sep 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment