refs #115: fix build duration #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is definitely a bug, but I think we need to analyze this more. It looks like the timestamp and duration are both incorrect. See this screenshot from 0.5 when it was last working:
The top value should display the timestamp and bottom value should display the duration. Right now it looks like the top value is always blank with a |
|
Opps, i supposed to display duration and timestamp, I'm going to fix it. |
|
@bradrydzewski fixed |
|
This ended up being a bit more complex since the fix also needed to take matrix build status into account. I ended up patching locally and pushing. Thanks for locating this issue though. I was able to build on your patch to get this fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build duration visibility (see issue)
cc/ @bradrydzewski