Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #427

Merged
merged 11 commits into from
Jan 3, 2023
Merged

Spelling #427

merged 11 commits into from
Jan 3, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 2, 2023

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/drone-ui/actions/runs/3824525381#summary-10400247024

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/drone-ui/actions/runs/3824525413#summary-10400247143

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most corrections automatically suggested by Google Sheets. All fault mine.

- \(maint\) document the release proceedure [\#421](https://github.com/drone/drone-ui/pull/421) ([tphoney](https://github.com/tphoney))
- \(maint\) document the release procedure [\#421](https://github.com/drone/drone-ui/pull/421) ([tphoney](https://github.com/tphoney))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects don't like changing changelogs. Happy to drop...

return () => window.document.body.style.oveflow = 'unset';
return () => window.document.body.style.overflow = 'unset';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notable

actice: undefined,
active: undefined,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable

<sub>That&aposs all we know.</sub>
<sub>That&apos;s all we know.</sub>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't strictly necessary, but it's nicer to not rely on this feature of the html parser...

Copy link
Contributor

@d1wilko d1wilko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me - thanks

@d1wilko d1wilko merged commit 9df5f0c into drone:main Jan 3, 2023
@jsoref jsoref deleted the spelling branch January 3, 2023 15:10
@d1wilko d1wilko added the bug label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants