Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store cron job that spawned build in Build struct and database #2628

Closed
bradrydzewski opened this issue Mar 20, 2019 · 7 comments
Closed

Store cron job that spawned build in Build struct and database #2628

bradrydzewski opened this issue Mar 20, 2019 · 7 comments
Milestone

Comments

@bradrydzewski
Copy link

bradrydzewski commented Mar 20, 2019

this can be used to visualize which cron job started a build, and can be used to enable support for using the cron job name in the when and trigger clauses.

example when configuration:

when:
  cron: [ nightly ]

example trigger configuration:

trigger:
  cron: [ nightly ]
@bradrydzewski bradrydzewski added this to the v1.1.0 milestone Apr 11, 2019
@bradrydzewski
Copy link
Author

support for triggers added by e855881

trigger:
  cron: [ nightly ]

support for when requires modifying compiler.SkipData in the drone-yaml library. This is a simple change. hopefully I will find time for this today or tomorrow.

bradrydzewski added a commit that referenced this issue Apr 13, 2019
@bradrydzewski
Copy link
Author

closed by 4ad4402 and e855881

@mvdan
Copy link

mvdan commented May 9, 2019

Perhaps I'm missing something obvious, but the when as shown above doesn't work for me. The step that's supposed to only run as part of that cron job always runs, including regular pushes to master and pull requests. I'm on 1.1.0.

@andrewrynhard
Copy link

I am seeing the same as @mvdan. Happy to look into the code, not sure where to start.

@mmack-innio
Copy link

Same here. Tried to trigger on cron [ hourly] and did not work.

@andrewrynhard
Copy link

This seems to only work for triggers.

@bradrydzewski
Copy link
Author

for this to fully work as envisioned, we also need #2705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants