Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: [CI-12179]: Add support for gitlab basesha for PRs #306

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

smjt-h
Copy link
Contributor

@smjt-h smjt-h commented May 8, 2024

No description provided.

Copy link

@ShobhitSingh11 ShobhitSingh11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems okay, wondering if we are supporting basesha then what will be use of headsha ans startsha

@smjt-h
Copy link
Contributor Author

smjt-h commented May 9, 2024

Code seems okay, wondering if we are supporting basesha then what will be use of headsha ans startsha

Base sha and Start sha are same, head sha is source branch sha, we are populating base sha as of now because of customer requirement. They want to use this variable in CI for gitlab PR builds

@smjt-h smjt-h merged commit 9e8b4ca into master May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants