Skip to content

Commit

Permalink
As requested by QA, I am reverting "[JBRULES-3219] decapitalize field…
Browse files Browse the repository at this point in the history
…s starting with an uppercase letter"

This reverts commit e972d85.
  • Loading branch information
etirelli committed Oct 4, 2011
1 parent 177c65a commit 46b2d3a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 44 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1221,46 +1221,6 @@ public void testDeclaredFactAndFunction() throws Exception {
list.get( 0 ) );
}

@Test
public void testUppercaseField() throws Exception {
String rule = "package org.drools;\n";
rule += "global java.util.List list\n";
rule += "declare Address\n";
rule += " Street: String\n";
rule += "end\n";
rule += "rule \"r1\"\n";
rule += "when\n";
rule += " Address($street: Street)\n";
rule += "then\n";
rule += " list.add($street);\n";
rule += "end\n";

final PackageBuilder builder = new PackageBuilder();
builder.addPackageFromDrl( new StringReader( rule ) );

if ( builder.hasErrors() ) {
fail( builder.getErrors().toString() );
}

KnowledgeBase kbase = loadKnowledgeBaseFromString(rule);
StatefulKnowledgeSession ksession = kbase.newStatefulKnowledgeSession();
ksession.setGlobal("list", new ArrayList<String>());

FactType addressType = kbase.getFactType("org.drools", "Address");
Object address = addressType.newInstance();
addressType.set(address, "Street", "5th Avenue");

ksession.insert(address);

ksession.fireAllRules();

List list = (List)ksession.getGlobal( "list" );
assertEquals(1, list.size());
assertEquals("5th Avenue", list.get(0));

ksession.dispose();
}

@Test
public void testNullHandling() throws Exception {
final PackageBuilder builder = new PackageBuilder();
Expand Down
3 changes: 1 addition & 2 deletions drools-core/src/main/java/org/drools/base/AccessorKey.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package org.drools.base;

import java.beans.*;
import java.io.Externalizable;
import java.io.IOException;
import java.io.ObjectInput;
Expand All @@ -42,7 +41,7 @@ public AccessorKey(String className,
AccessorType type) {
super();
this.className = className;
this.fieldName = Introspector.decapitalize(fieldName);
this.fieldName = fieldName;

final int PRIME = 31;
int result = 1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package org.drools.base;

import java.beans.*;
import java.io.Externalizable;
import java.io.IOException;
import java.io.ObjectInput;
Expand Down Expand Up @@ -52,7 +51,7 @@ public ClassFieldReader() {
public ClassFieldReader(final String className,
final String fieldName) {
this.className = className;
this.fieldName = Introspector.decapitalize(fieldName);
this.fieldName = fieldName;
}

public void writeExternal(ObjectOutput out) throws IOException {
Expand Down

0 comments on commit 46b2d3a

Please sign in to comment.