JBPM-4646 - Case management #601
Conversation
|
@cristianonicolai @krisv first version ready to be reviewed and merged |
| @@ -0,0 +1,61 @@ | |||
| /* | |||
| * Copyright 2015 Red Hat, Inc. and/or its affiliates. | |||
|
jenkins retest this |
|
|
||
| try { | ||
| // this should throw exception as there is no case any more | ||
| caseClient.getCaseInstance(CONTAINER_ID, caseId); |
There was a problem hiding this comment.
Adding a fail() in the next line would ensure that the exception was actually thrown in the test.
|
@mswiderski this looks really good, just some minor comments to fix. |
|
@cristianonicolai changes applied, thanks |
| @@ -0,0 +1,42 @@ | |||
| /* | |||
| * Copyright 2015 Red Hat, Inc. and/or its affiliates. | |||
|
license headers updated, thanks @cristianonicolai |
|
@mswiderski just spotted two test classes without license headers CaseServiceIntegrationTest and |
|
added missing license header to test classes and added updateComment endpoint to mirror services capabilities. |
mswiderski
force-pushed
the
case-mgmt
branch
3 times, most recently
from
321c8c6
to
ac43d06
Compare
|
@mswiderski one of the failures on jenkins is related to the jbpm-case-mgmt dependency on droolsjbpm-bpms-distribution/pom.xml. I guess that needs to be removed and the new modules added. |
|
droolsjbpm-bpms-distribution/src/main/assembly/pre-bin.xml also has an include to the old module. |
mswiderski
force-pushed
the
case-mgmt
branch
2 times, most recently
from
7b91072
to
f765c5a
Compare
|
@mswiderski thanks for noticing that! I've pushed your fix directory to master/6.5.x as this is a hot fix which is needed to make the build work. And sorry for the troubles... |
|
@psiroky @mariofusco I don't think blueprint test failures are related to this PR but just double checking. Any hints? |
|
@mswiderski the dependencies in here also need some checking https://github.com/droolsjbpm/droolsjbpm-integration/blob/master/droolsjbpm-bpms-distribution/pom.xml#L133, probably removing the old module and adding the two new ones. |
|
thanks @cristianonicolai @psiroky for helping out, now the build is green :) |
|
ready to be merged from my point of view |
|
Jenkins retest this |
|
+1 |
depends on kiegroup/jbpm#558