This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
[6.5.x] JBPM-5217 - Link each element of the process model to its location in the process documentation #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.facade.raiseEvent({ | ||
| type : ORYX.CONFIG.EVENT_NOTIFICATION_SHOW, | ||
| ntype : 'info', | ||
| msg : ORYX.I18N.ShapeMenuPlugin.unableToFindNodeSource, |
There was a problem hiding this comment.
Should line 343 be ORYX.I18N.ShapeMenuPlugin.unableToLinkElementToDocs ?
For this constant, maybe "Element not included in documentation" might be better, as the current message "Unable to..." makes it sound as though there's an error.
There was a problem hiding this comment.
Yeah that's better wording. Will change
… the process documentation
|
@JLindop amended per your code comment |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(JS changes only)
@JLindop : adds a new button in the shape menu for each node in the process.
when the new documentation icon in shape menu is clicked, the tab changes from process modeling to process documentation and the page scrolls the location where this element is defined.
Note: for sequence flows we only show sequence flows in the docs that have either their name, documentation or conditionexpression properties set. If the shape menu docs button is clicked on a sequence flow which does not have at least one of these elements set, designer shows a notification telling the user that element does not exist in the docs and does not switch to the docs tab. if the sequence flow has at least one of these elements the same applies as for any other node type.