[DROOLS-1129] consistent OSGi Bundle-SymbolicName for all jars #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,10 @@ | |||
| <packaging>bundle</packaging> | |||
| <name>jBPM :: KIE Services</name> | |||
|
|
|||
| <properties> | |||
| <osgi.Bundle-SymbolicName>org.jbpm.kie.services.api.jpa;singleton:=true</osgi.Bundle-SymbolicName> | |||
There was a problem hiding this comment.
api.jpa should not be in the bundle name - it was a typo previously. So I think it would make sense to fix it no. I don't think services api is used anywhere in osgi
|
+1 to merge would be good to fix the wrong name in jbpm-kie-services but not a must |
psiroky
force-pushed
the
d1129-osgi-metadata-fix
branch
from
35837d7
to
d2dfc2e
Compare
|
The test failure is not related (flaky timer test). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
kiegroup/droolsjbpm-build-bootstrap#183