Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest Zanata translation changes in kie-wb-common from 2016-06-27 #395

Merged

Conversation

kiereleaseuser
Copy link
Contributor

No description provided.

@@ -30,10 +30,10 @@ ContainerStatusEmptyView.Documentation=ドキュメント
ContainerStatusEmptyView.LearnMoreMessage=このトピックについての詳細はこちらで調べられます
ContainerStatusEmptyView.NoRemoteServers=リモートサーバーがありません
ContainerStatusEmptyView.Refresh=更新
ContainerView.ArtifactId=アーティファクト ID:
ContainerView.ArtifactId=アーティファクト ID\:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulovmr @psiroky Does this \ cause problems? IIRC there was chat about it in the past.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manstis Not anymore. This problem turned out to be a bug on Errai *.properties parser, which is already fixed. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this was fixed by Errai 3.2.4.Final (e.g. it will now filter out this \). However, it would definitely be worth verifying manually in the UI.

@manstis
Copy link
Member

manstis commented Jun 27, 2016

+1 to merge.

@mbiarnes
Copy link
Contributor

@manstis @paulovmr @bbrodt
I thought this is soloved with the new errai version?
maybe the binaries are still not available?
I will remove the ""

@paulovmr
Copy link
Member

@mbiarnes The "" are still there, but the problem will no longer happen, because the parser was fixed to work with escaped ":" (this case) and "=".

@mbiarnes mbiarnes force-pushed the kie-wb-common-ZanataChanges-2016-06-27 branch from 4562354 to dbbcad4 Compare June 27, 2016 13:38
@mbiarnes mbiarnes merged commit d8620c2 into kiegroup:6.4.x Jun 27, 2016
@mbiarnes mbiarnes deleted the kie-wb-common-ZanataChanges-2016-06-27 branch September 2, 2016 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants