JBPM-5467: Stunner - UXD palette integration #665
Conversation
|
@romartin can you review it? |
|
|
||
| private final static Map<String, Icon> CATEGORY_VIEWS = new HashMap<String, Icon>() {{ | ||
| private final static Map<String, IconResource> CATEGORY_RERNDERERS_SETTINGS = new HashMap<String, IconResource>() {{ |
There was a problem hiding this comment.
Typo (don't consider this an in depth review at this stage - I was just being nosy re: Case Management stuff)
There was a problem hiding this comment.
@manstis I'll wait your full review tomorrow ;)
|
jenkins retest this |
There was a problem hiding this comment.
Oh @pefernan , just realized that the user task icon, for the canvas side, does not appear! So it appears on the palette, but not in the canvas. Other task types are displaying the icons as expected, but the concrete user one seems that is not being rendered, no icon appears at all. I remember that there was some issue on that icon.. so could be related?
pefernan
force-pushed
the
JBPM-5467-stunner-palette
branch
from
73324b6
to
5ddb5c0
Compare
|
@romartin yes it was related with the changes on the task-user.svg. Just modified it again and now works fine. |
JBPM-5467: Stunner - UXD palette integration - Added full palette - Added D&D v1 JBPM-5467: Stunner - UXD palette integration - Fixed styling issues - Fixed added D&D on palette items. JBPM-5467: Stunner - UXD palette integration - Added icon rendering JBPM-5467: Stunner - UXD palette integration - Added more & less actions - Added icons - Added i18n JBPM-5467: Stunner - UXD palette integration - Fixing merge issues JBPM-5467: Stunner - UXD palette integration - API Changes - Added testing - Added hover on SVG's - Removing scrolls from CSS - Added animation via CSS - Fixed CSS - Fixed issues with task-user.svg
pefernan
force-pushed
the
JBPM-5467-stunner-palette
branch
from
5ddb5c0
to
9990c40
Compare
|
jenkins retest this |
1 similar comment
|
jenkins retest this |
There was a problem hiding this comment.
Hey @pefernan , good job again! Tested both Stunner showcases and the workbench, all works fine (just a few minor "visual" already known issues, that should be fixed by UXD in the templates). The commit changes are good as well, so for me +1
|
hey @manstis , I have tested the palette with a CM diagram and it seems that it works fine too. |
Added new Palette with the UXD designs