Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANNER-722: Workbench: Add import example option to Project Authoring perspective #130

Merged
merged 1 commit into from
Jan 23, 2017

Conversation

mcimbora
Copy link
Contributor

No description provided.

<!-- KIE Workbench Playground Repository -->
<dependency>
<groupId>org.kie.workbench.playground</groupId>
<artifactId>playground-parent</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The playground-parent's pom.xml's "packaging" type is "pom", yet that pom.xml has a side effect of building and deploying a jar too. Combine that with the fact that "packaging" defaults to "jar" and this works.

So maybe we should split up playground-parent into kie-playground-parent and kie-playground-distribution? The modules code would go into parent, but the assembly and xslt code would go into playground-distribution. optaplanner-wb would depend on distribution instead of parent.

Copy link
Collaborator

@ge0ffrey ge0ffrey Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge this PR as is and threat this comment in a separate set of PR's if you agree with it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ge0ffrey I agree the structure could be reworked to make things a bit more transparent. I created https://issues.jboss.org/browse/GUVNOR-2862 to fix this.

@csadilek csadilek merged commit b1bf0b3 into kiegroup:master Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants