-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle method.basicCancel #52
Comments
It doesn't do much, because all of these events are generally triggered by a publisher, but it's a good example of how error handling should be done. Start working on consume cancel notification. Requires dropbox/amqp-coffee#52 to be completed
What would you want it to do? I suppose emitting an error on the consumer could work? |
Maybe another kind or event such as 'cancel'? Error would, of course, work, but then we'll have to choose error code, structure it similarly to rabbitmq response, and this is likely undesirable
|
yeah, i really hate adding random emitters, everything but errors are callback based. I think ill add the cancel listener and fall back to error if there isn't a cancel listener. |
When we have the following options and #51 is merged in consumer gets new events
Example log:
It would be nice to have https://github.com/dropbox/amqp-coffee/blob/master/src/lib/Consumer.coffee#L196 extended with a handler for such an event (https://www.rabbitmq.com/consumer-cancel.html). It could simply emit an event, which a user must handle, or automatically try to reconnect. To synthetically generate such an event - create a consumer and then purge queue/exchange in the rabbitmq management console
The text was updated successfully, but these errors were encountered: