Rename date started to date created

Summary: Fixes T33043

Test Plan: VM

Reviewers: kylec

Reviewed By: kylec

Subscribers: kylec, changesbot, dfb-reviews, reviews-dfbgrowth, christoffer

Maniphest Tasks: T33043

Differential Revision: https://tails.corp.dropbox.com/D93500

changes/listeners/mail.py

@@ -110,16 +110,22 @@ def get_msg(self, context):
         return msg
 
     def get_subject(self, target, label, result):
+        # Use the first label line for multi line labels.
+        if label:
+            lines = label.splitlines()
+            if len(lines) > 1:
+                label = u"{}...".format(lines[0])
+
         format_dict = {
             'target': target,
             'label': label,
             'verb': str(result).lower(),
         }
 
         if target:
-            return "{target} {verb} - {label}".format(**format_dict)
+            return u"{target} {verb} - {label}".format(**format_dict)
         else:
-            return "Build {verb} - {label}".format(**format_dict)
+            return u"Build {verb} - {label}".format(**format_dict)
 
     def get_collection_context(self, builds):
         """
@@ -157,7 +163,7 @@ def sort_builds(builds_context):
         build = builds[0]
         target, target_uri = self.get_build_target(build)
 
-        date_started = min([_build.date_created for _build in builds])
+        date_created = min([_build.date_created for _build in builds])
 
         return {
             'title': self.get_subject(target, build.label, result),
@@ -166,7 +172,7 @@ def sort_builds(builds_context):
             'target_uri': target_uri,
             'target': target,
             'label': build.label,
-            'date_started': date_started,
+            'date_created': date_created,
             'author': build.author,
             'commit_message': build.message or '',
             'failing_tests_count': aggregate_count(builds_context, 'failing_tests_count'),

templates/listeners/mail/notification.html

@@ -141,7 +141,7 @@
 <pre class="patch-info">
 <a href="{{ target_uri }}" class="dark-link">{% if target %}{{ target }}{% else %}Source{% endif %}: <span class="link-cue">{{ label }}</span></a>
 Author: {{ author.name }} &lt;<a href="mailto:{{ author.email }}?subject={{ target }}: {{ label}}">{{ author.email }}</a>&gt;
-{% if date_started %}Started: {{ date_started.strftime('%a %b %d %H:%M:%S %Y') }}{% endif %}
+Created: {{ date_created.strftime('%a %b %d %H:%M:%S %Y') }}
 
 {{
     commit_message|break_long_lines(

templates/listeners/mail/notification.txt

@@ -4,7 +4,7 @@
     {{label}}
 {%- endif %}
 Author: {{ author.name }} <{{ author.email }}>
-{% if date_started %}Started: {{ date_started.strftime('%a %b %d %H:%M:%S %Y') }}{% endif %}
+Created: {{ date_created.strftime('%a %b %d %H:%M:%S %Y') }}
 
 {{
     commit_message|break_long_lines(

tests/changes/listeners/test_mail.py

@@ -11,6 +11,27 @@
 from changes.testutils.cases import TestCase
 
 
+class MailNotificationHandlerTestCase(TestCase):
+    def test_get_subject(self):
+        handler = MailNotificationHandler()
+
+        self.assertEqual(
+            'D123 passed - My \u00fcnicode diff',
+            handler.get_subject('D123', 'My \u00fcnicode diff', Result.passed),
+        )
+
+        self.assertEqual(
+            'Build passed - My \u00fcnicode diff',
+            handler.get_subject(None, 'My \u00fcnicode diff', Result.passed),
+        )
+
+        self.assertEqual(
+            'Build passed - My \u00fcnicode diff...',
+            handler.get_subject(
+                None, 'My \u00fcnicode diff\nwith many lines', Result.passed),
+        )
+
+
 class FilterRecipientsTestCase(TestCase):
     def test_simple(self):
         results = filter_recipients(