Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Commit

Permalink
JS fix for bazel targets
Browse files Browse the repository at this point in the history
Summary: This error occurs because for jobstep that builds bazel targets, we store the tests under `data['targets']`, not `data['tests']`.

Test Plan: ran against staging

Reviewers: kylec, anupc

Reviewed By: anupc

Subscribers: changesbot

Tags: #changes_ui

Differential Revision: https://tails.corp.dropbox.com/D228207
  • Loading branch information
Naphat Sanguansin committed Sep 13, 2016
1 parent a0162d7 commit 2d7fc45
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions webapp/pages/tests_for_build_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -429,10 +429,11 @@ var ShardingTab = React.createClass({
links.push(<a className="marginRightM" href={logHref}>Log</a>);
}
links.push(<a className="marginRightM" onClick={onClick}>{expandLabel}</a>);
let tests = (step.data.tests === undefined) ? step.data.targets : step.data.tests;
rows.push([
step.node && step.node.name,
step.data.weight,
step.data.tests.length,
tests.length,
links
]);

Expand All @@ -447,7 +448,7 @@ var ShardingTab = React.createClass({
rows.push(GridRow.oneItem(null,
<div>
<b>Files:</b>
<pre>{step.data.tests.join("\n")}</pre>
<pre>{tests.join("\n")}</pre>
</div>
));
});
Expand Down

0 comments on commit 2d7fc45

Please sign in to comment.