Fix diff-trigger and commit-trigger rendering

Summary: This was wrong because both "1" and "0" cast to true.

Reviewers: kylec, paulruan

Reviewed By: paulruan

Subscribers: changesbot

Tags: #changes_ui

Differential Revision: https://tails.corp.dropbox.com/D223743

webapp/pages/all_projects_page.js

@@ -201,12 +201,12 @@ var AllProjectsPage = React.createClass({
 
       var repo_rows = _.map(repo_projects, (p, index) => {
         var triggers = "Never";
-        if (p.options["phabricator.diff-trigger"] &&
-            p.options["build.commit-trigger"]) {
+        if (p.options["phabricator.diff-trigger"] === "1" &&
+            p.options["build.commit-trigger"] === "1") {
           triggers = "Diffs and Commits";
-        } else if (p.options["phabricator.diff-trigger"]) {
+        } else if (p.options["phabricator.diff-trigger"] === "1") {
           triggers = "Only Diffs";
-        } else if (p.options["build.commit-trigger"]) {
+        } else if (p.options["build.commit-trigger"] === "1") {
           triggers = "Only Commits";
         }
 

webapp/pages/project_page/details_tab.js

@@ -69,8 +69,8 @@ var DetailsTab = React.createClass({
   },
 
   renderHeader: function(project, plans) {
-    var builds_on_diffs = project.options["phabricator.diff-trigger"];
-    var builds_on_commits = project.options["build.commit-trigger"];
+    var builds_on_diffs = project.options["phabricator.diff-trigger"] === "1";
+    var builds_on_commits = project.options["build.commit-trigger"] === "1";
 
     var triggers = 'Does not automatically run';
     if (builds_on_commits && builds_on_diffs) {