fixes an error where it is possible for a test suite date_created to …

…be None when that test suite is empty

Summary: This fixes an issue where if a test suite has no test cases, it might have a None value for date_created.

Test Plan: unit tests

Reviewers: anupc, kylec

Reviewed By: kylec

Subscribers: changesbot, kylec

Differential Revision: https://tails.corp.dropbox.com/D225465

changes/artifacts/xunit.py

@@ -1,6 +1,7 @@
 from __future__ import absolute_import, division
 
 import logging
+from datetime import datetime
 from operator import add
 from xml.parsers import expat
 from xml.sax import saxutils
@@ -263,6 +264,9 @@ def end(self, tag):
 
                 if self.test_suites[-1].date_created is None:
                     self.test_suites[-1].date_created = min([t.date_created for t in self.test_suites[-1].test_results])
+            else:
+                if self.test_suites[-1].date_created is None:
+                    self.test_suites[-1].date_created = datetime.utcnow()
         elif tag == 'testcase':
             if self._current_result.result == Result.unknown:
                 # Default result is passing

tests/changes/artifacts/test_xunit.py

@@ -39,6 +39,7 @@ def test_get_test_single_suite(xml, suite_name, duration):
     assert suites[0].name == suite_name
     assert suites[0].duration == duration
     assert suites[0].result == Result.failed
+    assert suites[0].date_created is not None
 
     # test the equivalence of get_tests and get_test_suites in the case where
     # there is only one test suite, so that we can call get_tests directly
@@ -79,16 +80,19 @@ def test_get_test_suite_multiple():
     assert suites[0].name is None
     assert suites[0].duration is None
     assert suites[0].result == Result.failed
+    assert suites[0].date_created is not None
     assert len(suites[0].test_results) == 3
 
     assert suites[1].name == 'suite2'
     assert suites[1].duration == 77
     assert suites[1].result == Result.failed
+    assert suites[1].date_created is not None
     assert len(suites[1].test_results) == 3
 
     assert suites[2].name == ''
     assert suites[2].duration is None
     assert suites[2].result == Result.failed
+    assert suites[2].date_created is not None
     assert len(suites[2].test_results) == 3
 
     tests = handler.aggregate_tests_from_suites(suites)
@@ -117,11 +121,13 @@ def test_get_test_suite_multiple_empty(xml, result):
     assert suites[0].name == 'suite-name'
     assert suites[0].duration is None
     assert suites[0].result is result
+    assert suites[0].date_created is not None
     assert len(suites[0].test_results) == 0
 
     assert suites[1].name == 'null'
     assert suites[1].duration is None
     assert suites[1].result == Result.passed
+    assert suites[1].date_created is not None
     assert len(suites[1].test_results) == 1