Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Commit

Permalink
no longer using path name in artifact name for bazel project
Browse files Browse the repository at this point in the history
Summary: Turns out this is no longer necessary if we save the relative path properly - it is exactly equivalent in terms of uniqueness.

Test Plan: N/A

Reviewers: anupc

Reviewed By: anupc

Subscribers: changesbot, kylec

Differential Revision: https://tails.corp.dropbox.com/D225216
  • Loading branch information
Naphat Sanguansin committed Sep 1, 2016
1 parent d9ca2b7 commit 5c03360
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion changes/models/jobplan.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ def get_build_step_for_job(cls, job_id):
cpus=bazel_cpus,
memory=bazel_memory,
max_executors=bazel_max_executors,
use_path_in_artifact_name=True,
)
return jobplan, implementation

Expand Down
3 changes: 0 additions & 3 deletions tests/changes/models/test_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ def test_autogenerated_commands(self, get_config):
assert implementation.artifacts == []
assert implementation.artifact_suffix == '.bazel'

assert implementation.use_path_in_artifact_name is True

assert implementation.commands[0].type == CommandType.setup
assert implementation.commands[0].script == bazel_setup_expected

Expand Down Expand Up @@ -126,7 +124,6 @@ def test_autogenerated_commands_with_exclusions(self, get_config):

assert implementation.max_executors == 3

assert implementation.use_path_in_artifact_name is True
assert implementation.artifacts == []
assert implementation.artifact_suffix == '.bazel'

Expand Down

0 comments on commit 5c03360

Please sign in to comment.