Don't warn about uncategorized logs

Summary:
There's a strong case that we should remove the categorization logic altogether,
but we certainly don't need to be warned when we fail to categorize, as that isn't
a problem, and I don't think we're even trying to categorize.

Test Plan: CHanges

Reviewers: josiah

Reviewed By: josiah

Subscribers: changesbot

Differential Revision: https://tails.corp.dropbox.com/D221609

changes/listeners/analytics_notifier.py

@@ -234,16 +234,6 @@ def _categorize_step_logs(job):
             _incr("failing-log-processed")
             if not tags and applicable:
                 _incr("failing-log-uncategorized")
-                logger.warning("Uncategorized log", extra={
-                    # Supplying the 'data' this way makes it available in log handlers
-                    # like Sentry while keeping the warnings grouped together.
-                    # See https://github.com/getsentry/raven-python/blob/master/docs/integrations/logging.rst#usage
-                    # for Sentry's interpretation.
-                    'data': {
-                        'logsource.id': ls.id.hex,
-                        'log.url': ls.get_url(),
-                    }
-                })
             else:
                 for tag in tags:
                     _incr("failing-log-category-{}".format(tag))

tests/changes/listeners/test_analytics_notifier.py

@@ -247,10 +247,8 @@ def test_no_tags(self, get_rules_fn, categorize_fn):
 
         tags_by_step = None
         with mock.patch('changes.listeners.analytics_notifier._incr') as incr:
-            with mock.patch('changes.listeners.analytics_notifier.logger.warning') as warn:
-                tags_by_step = _categorize_step_logs(job)
-                warn.assert_any_call(mock.ANY, extra=mock.ANY)
-                incr.assert_any_call("failing-log-uncategorized")
+            tags_by_step = _categorize_step_logs(job)
+            incr.assert_any_call("failing-log-uncategorized")
 
         categorize_fn.assert_called_with('project-slug', fake_rules, 'Some log text')
         self.assertSetEqual(tags_by_step[step.id], set())