Put diff build result icon on the same line as the message

Summary: Having them on separate lines makes them take up a lot of vertical space

Test Plan: none

Reviewers: wwu, zev

Reviewed By: wwu

Subscribers: wwu, josiah, vishal, changesbot

Differential Revision: https://tails.corp.dropbox.com/D94064

changes/listeners/phabricator_listener.py

@@ -91,13 +91,13 @@ def build_finished_handler(build_id, **kwargs):
 
     result_image = ''
     if build.result == Result.passed:
-        result_image = 'green-check'
+        result_image = '{icon check, color=green}'
     elif build.result == Result.failed:
-        result_image = 'red-x'
+        result_image = '{icon times, color=red}'
     else:
-        result_image = 'yellow-question'
+        result_image = '{icon question, color=orange}'
 
-    message = u'{image}\nBuild {result} - {project} #{number} ({target}). Build Results: [link]({link})'.format(
+    message = u'Build {result} {image} - [{project} #{number}]({link}) ({target}).'.format(
         image=result_image,
         number='{0}'.format(build.number),
         result=unicode(build.result),

tests/changes/listeners/test_phabricator.py

@@ -47,7 +47,7 @@ def test_whitelisted_project(self, get_options, phab):
         get_options.assert_called_once_with(project.id)
         build_link = build_uri('/projects/{0}/builds/{1}/'.format(
             build.project.slug, build.id.hex))
-        expected_msg = "red-x\nBuild Failed - test #1 (D1). Build Results: [link]({0})".format(
+        expected_msg = "Build Failed {{icon times, color=red}} - [test #1]({0}) (D1).".format(
             build_link)
 
         phab.assert_called_once_with('1', expected_msg)