Split failing tests long truncated name to two lines: shortname and p…

…ackage Summary: https://www.dropbox.com/s/wogyar51vwvekvk/Screenshot%202015-01-15%2015.06.35.png?dl=0 Reviewers: vishal Reviewed By: vishal Projects: #changes Maniphest Tasks: T27265 Differential Revision: https://tails.corp.dropbox.com/D84537
dropbox · Jan 23, 2015 · a62a7d9 · a62a7d9
1 parent 01ad552
commit a62a7d9
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 15 deletions.
diff --git a/partials/includes/job-test-failures.html b/partials/includes/job-test-failures.html
@@ -1,4 +1,4 @@
-<section class="section" ng-if="testFailures.total">
+<section class="section job-test-failures" ng-if="testFailures.total">
     <div class="section-header">
         <h3>
             Failing Tests
@@ -25,20 +25,26 @@ <h3>
                     <td>
                         <span class="indicator indicator-sm"></span>
 
-                        <a ui-sref="test_details({job_id: testCase.job.id, test_id: testCase.id})">{{testCase.name|truncate:80}}</a><br>
-                        <small>
-                            <a ui-sref="project_test_details({test_id: testCase.hash})">History</a>
-                            <!-- <span ng-if="testCase.origin">
-                                &mdash; This failure likely originated in
-                                    <span ng-if="testCase.origin.source.id == build.source.id">
-                                        this changeset
-                                    </span>
-                                    <span ng-if="testCase.origin.source.id != build.source.id">
-                                        <a href="{{testCase.origin.link}}">{{testCase.origin.target}}</a>
-                                        <span ng-if="testCase.origin.author"> &mdash; {{testCase.origin.author.name}}</span>
-                                    </span>
-                            </span> -->
-                        </small>
+                        <span class="test-item-content">
+                            <a ui-sref="test_details({job_id: testCase.job.id, test_id: testCase.id})"
+                                    ng-bind="testCase.shortName">
+                            </a>
+                            <small>
+                                <div class="test-item-package" ng-bind="testCase.package">
+                                </div>
+                                <a ui-sref="project_test_details({test_id: testCase.hash})">History</a>
+                                <!-- <span ng-if="testCase.origin">
+                                    &mdash; This failure likely originated in
+                                        <span ng-if="testCase.origin.source.id == build.source.id">
+                                            this changeset
+                                        </span>
+                                        <span ng-if="testCase.origin.source.id != build.source.id">
+                                            <a href="{{testCase.origin.link}}">{{testCase.origin.target}}</a>
+                                            <span ng-if="testCase.origin.author"> &mdash; {{testCase.origin.author.name}}</span>
+                                        </span>
+                                </span> -->
+                            </small>
+                        </span>
                     </td>
                     <td class="column" duration="testCase.duration"></td>
                 </tr>

diff --git a/static/css/styles.css b/static/css/styles.css
@@ -1564,6 +1564,16 @@ d3barchart {
   font-size: 1.3em;
 }
 
+.job-test-failures .grid-list {
+  table-layout: fixed;
+}
+
+.test-item-content, .test-item-content .test-item-package  {
+  display: block;
+  text-overflow: ellipsis;
+  overflow: hidden;
+}
+
 .build-log-container {
   background: #fff;
 }