Specify is_diff in the JenkinsTestCollectorBuildStep

Summary: We want the same diff-dependent settings for collected tests as for their parent.

Test Plan: None

Reviewers: kylec

Subscribers: wwu

Differential Revision: https://tails.corp.dropbox.com/D84355

changes/backends/jenkins/buildsteps/test_collector.py

@@ -228,10 +228,12 @@ def _expand_job(self, phase, job_config):
                 path=step.data['path'],
             )
 
+            is_diff = not step.job.source.is_commit()
             job_data = builder.create_job_from_params(
                 target_id=step.id.hex,
                 params=params,
                 job_name=step.data['job_name'],
+                is_diff=is_diff
             )
             step.data.update(job_data)
             db.session.add(step)

tests/changes/backends/jenkins/buildsteps/test_test_collector.py

@@ -170,10 +170,12 @@ def test_job_expansion(self, get_test_stats, get_builder):
         builder.create_job_from_params.assert_any_call(
             job_name='foo-bar',
             target_id=new_steps[0].id.hex,
+            is_diff=False,
             params=builder.get_job_parameters.return_value,
         )
         builder.create_job_from_params.assert_any_call(
             job_name='foo-bar',
             target_id=new_steps[1].id.hex,
+            is_diff=False,
             params=builder.get_job_parameters.return_value,
         )