Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Commit

Permalink
Increase build context test limit
Browse files Browse the repository at this point in the history
Summary:
The phabricator messaging code in particular doesn't use the count, and assumes the test list
is complete, which means that limiting tests will be potentially confusing and wrong.
This bumps us to a large enough limit that if we're limiting you, it's probably not worth
looking at individual tests anyway while still avoiding some pathological scenarios.

More complete fixes to come later.

Test Plan: None

Reviewers: paulruan

Reviewed By: paulruan

Subscribers: changesbot, anupc

Differential Revision: https://tails.corp.dropbox.com/D232071
  • Loading branch information
kylec1 committed Sep 27, 2016
1 parent a049cea commit d8ac659
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion changes/lib/build_context_lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def _get_build_context(build, get_parent=True):

def _get_job_context(job):
# type: (Job) -> Dict[str, Any]
def get_job_failing_tests(job, limit=30):
def get_job_failing_tests(job, limit=500):
failing_tests = TestCase.query.options(
subqueryload_all('messages')
).filter(
Expand Down

0 comments on commit d8ac659

Please sign in to comment.