Deprecate saving new files to S3

Summary: Nothing should be using S3 anymore

Reviewers: paulruan

Reviewed By: paulruan

Subscribers: changesbot, kylec

Differential Revision: https://tails.corp.dropbox.com/D220192

changes/storage/s3.py

@@ -39,12 +39,7 @@ def get_file_path(self, filename):
         return '/'.join([self.path.rstrip('/'), filename])
 
     def save(self, filename, fp, content_type=None, path=None):
-        key = self.bucket.new_key(self.get_file_path(filename))
-        if content_type:
-            key.content_type = content_type
-        key.set_contents_from_file(fp)
-        key.set_acl('private')
-        return filename
+        raise NotImplementedError('Saving artifacts to S3 is deprecated')
 
     def url_for(self, filename, expire=300):
         key = self.bucket.get_key(self.get_file_path(filename))

tests/changes/storage/test_s3.py

@@ -23,7 +23,9 @@ def test_simple(self):
             bucket='foo',
             path='artifacts/',
         )
-        storage.save('filename.txt', fp)
+        key = storage.bucket.new_key(storage.get_file_path('filename.txt'))
+        key.set_contents_from_file(fp)
+        key.set_acl('private')
 
         result = storage.url_for('filename.txt')
         assert result.startswith('https://foo.s3.amazonaws.com/artifacts/filename.txt?')