Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't apply the LifecycleBasePlugin if already applied #36

Merged
merged 2 commits into from
Jun 8, 2022
+6 −6
Merged

Don't apply the LifecycleBasePlugin if already applied #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a3ad75
Don't apply the LifecycleBasePlugin if already applied
ZacSweers May 31, 2022
3f4c5f1
Only apply when base plugin is applied
ZacSweers May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...guard/src/main/kotlin/com/dropbox/gradle/plugins/dependencyguard/DependencyGuardPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@ public class DependencyGuardPlugin : Plugin<Project> {
}

private fun attachToCheckTask(target: Project, dependencyGuardTask: TaskProvider<DependencyGuardListTask>) {
// Required to add the "check" lifecycle task
target.plugins.apply(LifecycleBasePlugin::class.java)

// Attach the "dependencyGuard" task to the "check" lifecycle task
target.tasks.named(LifecycleBasePlugin.CHECK_TASK_NAME).configure {
this.dependsOn(dependencyGuardTask)
// Only add to the "check" lifecycle task if the base plugin is applied
target.pluginManager.withPlugin("base") {
// Attach the "dependencyGuard" task to the "check" lifecycle task
target.tasks.named(LifecycleBasePlugin.CHECK_TASK_NAME).configure {
this.dependsOn(dependencyGuardTask)
}
}
}

Expand Down