Move Validation to afterEvaluate #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handstandsam
commented
Mar 13, 2023
| * Without adding this, there were cases when the `target.configurations` were not all available yet. | ||
| */ | ||
| private fun validateConfigurationAfterEvaluate(target: Project, extension: DependencyGuardPluginExtension) { | ||
| target.afterEvaluate { |
There was a problem hiding this comment.
afterEvaluate is required because with out it target.configurations.map { it.name } is not right in all projects.
handstandsam
force-pushed
the
validation-after-evaluate
branch
from
9865acc
to
402d000
Compare
This was referenced Mar 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should finally fix #68. I've validated it fixes the issues found in an old commit of a non-public monolith that required workarounds to fix previously.