Fix diff text lines missing

[SimonMarquis]

The \n was added only if the first condition was false because of if/else priorities.

if (a) {
  /**/
} else if (b) {
  /**/
} else {
  /**/
} + x

is in fact executed as

if (a) {
  /**/
} else {
    if (b) {
      /**/
    } else {
      /**/
    } + x
}

Closing #94

[SimonMarquis]

We probably should add tests to avoid future regressions.

[handstandsam]

Would a stringBuilder be good here? You could use .append() and .appendLine() instead of the \n char?

[SimonMarquis]

Yes, it will work as well. I would prefer using the same methods on both colored and non-colored outputs. I'll try to come up with something better.

[handstandsam]

| "We probably should add tests to avoid future regressions."

What isn't covered? I think because we're on 0.5.x and haven't cut it yet, ideally we should be adding tests in now. I felt like 0.4.x ended up being pretty crazy running around trying to fix config cache, so the more tests the better!

--

Thank you for the PR!

[SimonMarquis]

The current tests were asserting on the Gradle exception message.

[SimonMarquis]

The new version now uses StringBuilder, which makes new lines automatically handled.
Also, I removed the dependency of diffTextWithPlusAndMinusWithColor on diffTextWithPlusAndMinus. They now only rely on diffLines. This makes it more straightforward, as we no longer have to check for "empty" lines and unexpectedly produce a double line break.

[handstandsam]

Sounds good. Is this ready to merge? Looked fine.

[SimonMarquis]

Yup, ready to be merged 👌