Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

djinni doesn't respect namespace'd cpp objects always #38

Closed
wants to merge 3 commits into from
Closed

djinni doesn't respect namespace'd cpp objects always #38

wants to merge 3 commits into from

Conversation

skabbes
Copy link
Contributor

@skabbes skabbes commented Dec 4, 2014

Applies a more incremental fix for #28

@skabbes
Copy link
Contributor Author

skabbes commented Dec 4, 2014

@j4cbo this commit 2f35bd2 exposes the original problem, and the fix. Other commits are garbage, adding namespaces to the handwritten sources

@mknejp mknejp mentioned this pull request Apr 8, 2015
Closed
@skabbes
Copy link
Contributor Author

skabbes commented Apr 8, 2015

Actual fix was landed here: 21fecda

@skabbes skabbes closed this Apr 8, 2015
KhalilBellakrid added a commit to KhalilBellakrid/djinni that referenced this pull request Nov 18, 2019
@KhalilBellakrid
Merge pull request dropbox#38 from KhalilBellakrid/fix-scala-callbacks
06f600b 
Fix scala callback generation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@skabbes