Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

Add support for running Djinni with Git Bash on Windows #423

Merged
merged 2 commits into from Dec 30, 2018

Conversation

mpiannucci
Copy link
Contributor

When running with git bash, the platform is MSYS_NT so a conditional had to be added to allow generation to run the correct batch file when using this platform.

@xianwen
Copy link

xianwen commented Dec 27, 2018

Hi, @mpiannucci:
I noticed you haven't signed the CLA yet, could you please sign it here: https://opensource.dropbox.com/cla/
Thanks a lot!

@mpiannucci
Copy link
Contributor Author

Thanks! signed!

@xianwen xianwen merged commit 625c78d into dropbox:master Dec 30, 2018
codingrhythm pushed a commit to SafetyCulture/djinni that referenced this pull request Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants