This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Correct namespace for ObjcProxy return types #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4cbo
added a commit
that referenced
this pull request
Apr 8, 2015
Correct namespace for ObjcProxy return types
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where the Objective-C++ namespace is different from the C++ namespace.
In a code base I'm working on, for instance, the Objective-C++ namespace is set to "djinni_generated", whereas the C++ namespace is like "foo::bar". Djinni would produce broken Objective-C++ code before this patch in that configuration.
If these namespaces should always be identical, then either the C++ namespace should be forced single-level or the Objective-C++ namespace should be able to be multi-level. Currently, if one has picked a multi-level C++ namespace, one is forced to have a separate Objective-C++ namespace.
I'm guessing that the behavior prior to this patch is an accident, since the absolute C++ namespace is inserted on the type in the constructor.