Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds queries to SDK manifest #509

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Adds queries to SDK manifest #509

merged 2 commits into from
Nov 30, 2023

Conversation

rharter
Copy link
Contributor

@rharter rharter commented Aug 9, 2023

Adding the queries element to the SDK's manifest means that consumers don't need to.

@rharter rharter requested a review from devPalacio August 9, 2023 21:32
@rharter rharter self-assigned this Aug 9, 2023
@greg-db
Copy link
Contributor

greg-db commented Aug 10, 2023

Please be sure to fully test the auth flow with the official Dropbox Android app installed with this change.

Also, make sure that nothing breaks in the case where the app already has the queries set in its own manifest too.

As long as that all works fine, let's take out the "Add Dropbox package to queries" section of the documentation along with this change. Thanks!

@greg-db
Copy link
Contributor

greg-db commented Aug 10, 2023

Actually, small change to my previous comment; don't remove the documentation with this change itself. Remove the documentation once this change goes out in a release.

@rharter rharter changed the base branch from rharter/structure to main November 29, 2023 20:08
@wdziemia
Copy link
Contributor

@greg-db Ill be integrating with the snapshot before the 6.0.0 release goes out and and will make changes to the docs when bumping the snapshot version.

@rharter
Copy link
Contributor Author

rharter commented Nov 29, 2023

I'm not sure we're set up with build level integration tests to be able to write automated tests for these cases, but I've manually tested these two cases using the example app to validate that they don't present an issue.

  • If I have the queries block already defined, the merge manifest task doesn't bomb on duplicate
  • If I dont have the queries block defined, the merged manifest includes the queries block

@rharter rharter merged commit 68f4dee into main Nov 30, 2023
3 checks passed
@rharter rharter deleted the rharter/android-queries branch November 30, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants