error property on Error object is sometimes a string

[jvilk]

Version: 2.5.7

The error property on Error objects is supposed to be an object. However, it is sometimes a string.

In addition, both the user_message and error_summary fields are missing on the Error object.

I am very worried now that my Dropbox code will randomly fail because server messages fail to correspond to the appropriate Stone data type. I'm not feeling too good about the switch to V2.

Example

Code:

client.filesGetMetadata({ path: "" }).catch(function(e) {
  console.log(typeof(e.error));
  console.log(e.error);
});

Output:

"string"
"Error in call to API function "files/get_metadata": request body: path: The root folder is unsupported."

Expectation:

e.error is a GetMetadataErrorPath (which is what the documentation says it should be).

Expected output:

"object"
{ '.tag': 'path', path: { /* a LookupError */ }}

[jvilk]

Here's another example for create folder. e.error is the following string:

"Error in call to API function "files/create_folder": request body: path: 'tmp' did not match pattern '(/(.|[\r\n]))|(ns:[0-9]+(/.)?)'"

[jvilk]

Another, from filesUpload (this is a string, not an object):

"{"error_summary": "too_many_write_operations/", "error": {"reason": {".tag": "too_many_write_operations"}}}"

[greg-db]

Thanks for the report! We're looking into it.

[greg-db]

We've updated the error handling in release v8.0.0, and added a note to the Upgrading document. Please upgrade to the latest version and let us know if you're still seeing any issues. Thanks!