Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatitble with configuration cache on Gradle 8.4 #40

Closed
WhosNickDoglio opened this issue Oct 28, 2023 · 2 comments
Closed

incompatitble with configuration cache on Gradle 8.4 #40

WhosNickDoglio opened this issue Oct 28, 2023 · 2 comments

Comments

@WhosNickDoglio
Copy link

WhosNickDoglio commented Oct 28, 2023

I tried integrating focus into a project using Gradle 8.4 with configuration cache enabled and got a warning regarding incompatibilities.

I've updated the sample project to Gradle 8.4 and enabled configuration cache as a reproducer and this is the warning I got:

3 problems were found storing the configuration cache, 1 of which seems unique.
- Task `:sample:createFocusSettings` of type `com.dropbox.focus.CreateFocusSettingsTask`: invocation of ‘Task.project’ at execution time is unsupported.
  See https://docs.gradle.org/8.4/userguide/configuration_cache.html#config_cache:requirements:use_project_during_execution

PR with reproducer:#41

@WhosNickDoglio
Copy link
Author

Lol just now noticing CreateFocusSettingsTask is marked as not compatible with configuration cache.
https://github.com/dropbox/focus/blob/20bb0275aba27402fb12adb58699c631f4b80af9/focus-gradle-plugin/src/main/kotlin/com/dropbox/focus/CreateFocusSettingsTask.kt#

@rharter
Copy link
Collaborator

rharter commented Oct 28, 2023

Yeah, it's inherently not compatible with config caching because it works by resolving a projects dependencies, which it can't do from the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants