Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve install instructions #2

Merged
merged 6 commits into from
Aug 20, 2015
Merged

Improve install instructions #2

merged 6 commits into from
Aug 20, 2015

Commits on Aug 19, 2015

  1. [install] Use Scala 2.11, not Scala 2.7 

    When I used Scala 2.7, I got a compiler error "not found: value math."
As far as I can tell, this is because Scala 2.7 doesn't include a
scala.math package (http://www.scala-lang.org/api/2.7.7/).  I tried
Scala 2.11.7 instead, and that worked fine.
    @clizzin
    clizzin committed Aug 19, 2015
    3 Configuration menu
    Copy the full SHA
    f71bb1d View commit details
    Browse the repository at this point in the history

  2. [install] Remove mention of libmysql-java 

    I think this is a reference to the mysql-connector-java library, a jar
for which is already part of the repo.  (Technically, it's bad to have
jars in repos, but we'll solve that problem another time.)
    @clizzin
    clizzin committed Aug 19, 2015
    Configuration menu
    Copy the full SHA
    4c8ad01 View commit details
    Browse the repository at this point in the history

  3. [install] Remove etherpad/appjet-eth-dev.jar from repo 

    The installation process modified the jar, so it seems like this is an
artifact particular to each person's development environment, not
something that should be checked in.
    @clizzin
    clizzin committed Aug 19, 2015
    Configuration menu
    Copy the full SHA
    5f80c00 View commit details
    Browse the repository at this point in the history

  4. [install] Update default values in bin/exports.sh 

    We also clean up exports.sh a bit so it's easy to tell what needs
customizing for new environments vs. what is supposed to work as-is.
These are hopefully more up-to-date and reasonable defaults for a
developer on OS X, and for developers not on OS X, hopefully the cleanup
helps clarify what likely needs customization.

One of the changes to default values is to use the scala-library.jar
within the given installation of Scala, not the repo's
scala-library.jar.  I don't know much about Scala, but it seems like a
better default to make SCALA, SCALA_HOME, and SCALA_LIBRARY_JAR all
match instead of SCALA_LIBRARY_JAR being a special snowflake that's
checked into the repo.
    @clizzin
    clizzin committed Aug 19, 2015
    Configuration menu
    Copy the full SHA
    f024292 View commit details
    Browse the repository at this point in the history

  5. [install] Remove lib/scala-library.jar 

    The bin/exports.sh script now advises developers to use the
scala-library.jar within their local installation of Scala.
    @clizzin
    clizzin committed Aug 19, 2015
    Configuration menu
    Copy the full SHA
    9c42abd View commit details
    Browse the repository at this point in the history

  6. [install] Add instructions for creating an account in development

    @clizzin
    clizzin committed Aug 19, 2015
    Configuration menu
    Copy the full SHA
    7913bf3 View commit details
    Browse the repository at this point in the history