Remove 'create pad' row from search autocomplete #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this is intended to be a feature, I suspect people select it accidentally more often than they do intentionally. Selecting this row issues a request to `/ep/pad/newpad?title=QUERY&r=POSITION`, where QUERY is the query in the search bar and POSITION is the position of the row. We saw this kind of URL in the request log for a user who accidentally created a pad. And anecdotally, I've personally selected this row by accident. Even if we remove this feature, it's relatively easy to create a new pad by clicking the New Pad button, so hopefully we're not taking too much away from users.
igorkofman
added a commit
that referenced
this pull request
Aug 20, 2015
…autocomplete Remove 'create pad' row from search autocomplete
jianiau
pushed a commit
to jianiau/hackpad
that referenced
this pull request
Aug 25, 2015
Update run-local.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@igorkofman
While this is intended to be a feature, I suspect people select it
accidentally more often than they do intentionally. Selecting this row
issues a request to
/ep/pad/newpad?title=QUERY&r=POSITION, where QUERYis the query in the search bar and POSITION is the position of the row.
We saw this kind of URL in the request log for a user who accidentally
created a pad. And anecdotally, I've personally selected this row by
accident.
Even if we remove this feature, it's relatively easy to create a new pad
by clicking the New Pad button, so hopefully we're not taking too much
away from users.