This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
[jpgcoder.cc] fix undefined behavior #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[lepton/src/lepton/jpgcoder.cc:2937]: (error) using uninitialized variable: mcu Signed-off-by: Bryon Gloden, CISSP庐 cissp@bryongloden.com
bryonglodencissp
commented
Nov 9, 2016
| @@ -2475,7 +2475,7 @@ bool decode_jpeg(const std::vector<std::pair<uint32_t, uint32_t> > & huff_input_ | |||
| int rstw; // restart wait counter | |||
|
|
|||
| int cmp, bpos, dpos; | |||
| int mcu, sub, csc; | |||
There was a problem hiding this comment.
Line no. 2478 | 1. declaring variable mcu without initializer
Line no. 2492 | 2. condition true, taking true branch
Line no. 2495 | 3. condition type != 218, taking true branch
Line no. 2496 | 4. condition (int)hpos >= hers, taking true branch
Line no. 2496 | 5. breaking from loop
Line no. 2509 | 6. condition type != 218, taking true branch
Line no. 2509 | 7. breaking from loop
Line no. 2933 | 8. condition early_eof_encrountered, taking true branch
Line no. 2937 | 9. using uninitialized value mcu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃悰 label: security
Greetings,
It's always good to initialize integer variables, at least to 0, because if we try to retrieve its value before it gets assigned any actual (non-garbage) value, then it results in undefined behavior, e.g. line number 2937 of lepton/src/lepton/jpgcoder.cc.
REF: http://cwe.mitre.org/data/definitions/457.html
Signed-off-by: Bryon Gloden, CISSP庐 cissp@bryongloden.com