Update the build and packaging script for Fedora 37. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add scheduled canary build. This feels like a necessary thing to have, especially in light of the GNOME 43 upgrade. * Move to correct folder. * Update installed packages. * add libgtk-4-dev for ubuntu Co-authored-by: Geoffry Song <goffrie@dropbox.com>
jewelpit
changed the title
|
|
This reverts commit 586ad95.
|
Okay now it's ready. |
goffrie
approved these changes
Dec 7, 2022
HOWTO_PACKAGE.md
Outdated
| Probably you have to run `build_packages.py` command with `sudo` permission which | ||
| means you should add your root account to the mock group. Otherwise, you will see | ||
| `The password you typed is invalid.` error. | ||
| 4. On a Fedora machine: |
There was a problem hiding this comment.
this numbering seems wrong ;)
There was a problem hiding this comment.
Step three knows what it did >:(
| @@ -29,7 +29,7 @@ cat <<EOF > $HOME/.rpmmacros | |||
| %_tmppath $(pwd)/rpmbuild | |||
| %_smp_mflags -j3 | |||
| %_signature gpg | |||
| %_gpg_name 3565780E | |||
There was a problem hiding this comment.
i was curious and it turns out this was rian hunter's key 😆
generate-rpm.sh
Outdated
Comment on lines
221
to
228
| # Old versions of the rpm delete these files in postun. Fortunately we have saved a backup. | ||
| if [ ! -e %{_libdir}/nautilus/extensions-4/libnautilus-dropbox.so ]; then | ||
| if [ -e %{_libdir}/nautilus/extensions-4/libnautilus-dropbox.so.bak ]; then | ||
| mv -f %{_libdir}/nautilus/extensions-4/libnautilus-dropbox.so{.bak,} | ||
| fi | ||
| fi | ||
|
|
||
| rm -f %{_libdir}/nautilus/extensions-3.0/libnautilus-dropbox.so.bak | ||
| rm -f %{_libdir}/nautilus/extensions-2.0/libnautilus-dropbox.so.bak | ||
| rm -f %{_libdir}/nautilus/extensions-4/libnautilus-dropbox.so.bak |
There was a problem hiding this comment.
I'm guessing this is not necessary any more
There was a problem hiding this comment.
Oh, right. Old versions wouldn't be touching this path anyway.
generate-rpm.sh
Outdated
Comment on lines
121
to
124
| if [ \$1 -gt 1 ] ; then | ||
| # Old versions of the rpm delete the files in postun. So just in case let's make a backup copy. The backup copy will be restored in posttrans. | ||
| ln -f %{_libdir}/nautilus/extensions-3.0/libnautilus-dropbox.so{,.bak} | ||
| ln -f %{_libdir}/nautilus/extensions-2.0/libnautilus-dropbox.so{,.bak} | ||
| ln -f %{_libdir}/nautilus/extensions-4/libnautilus-dropbox.so{,.bak} | ||
| fi |
|
I just upgraded to F37. But still can't find the package.
sorry if I missed something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Ubuntu dropped support for building RPMs in 20.04, but we need to build against a version of GNOME that didn't ship until Ubuntu 22.10, we have to split the build into a
.debhalf and a.rpmhalf. The.debhalf must be run under Debian or Ubuntu, while the.rpmhalf must be run on a Fedora or RHEL machine. This allows us to release coreyberla's fix, resolving #108 and #101.New package metadata (package name and signature match):
Old package metadata: