Add tests to the canary job. #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
goffrie
approved these changes
Feb 27, 2023
dropbox_test.py
Outdated
| def raise_error(s): | ||
| raise FatalVisibleErrorForTest(s) | ||
|
|
||
| setattr(dropbox, "FatalVisibleError", raise_error) |
There was a problem hiding this comment.
maybe use patch + assert_called instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds not just the existing automated test suite, but also adds a new test to make sure that the latest versions of Ubuntu and Fedora are correctly included in the set of versions we support, since we use those values to generate the package repos.
I've left the supported versions list unchanged for the first iteration of this PR so that we can see the canary job fail, and I'll update them before merging.