-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packaging scripts to build in Docker #119
Conversation
4a0a3c8
to
0a9e63d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than the git clean
part :)
build_packages.sh
Outdated
|
||
set -euxo pipefail | ||
|
||
git clean -fdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we either remove this or make it an interactive clean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also in favor of removing it. I suspect it was included in the original build_packages.py
since this had to be run locally, but since we are moving to CI, where the checkout will always be clean, there is no value for release builds, and it's fairly anti-social if you're just testing locally.
@@ -17,3 +18,5 @@ for DIST in $DISTS; do | |||
|
|||
createrepo $DIST | |||
done | |||
|
|||
cd ../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not strictly necessary as this is run inside Docker. I added it so that if you run the script locally on your machine (outside Docker), it leaves you in the same directory that you started (the top-level repo root). I'll add a comment, but am happy to remove it if it causes some other problem
|
||
4. Copy `rpm_resources/.rpmmacros` to `~/.rpmmacros` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so glad to see the .rpmmacros
stuff gone!
0a9e63d
to
3caff23
Compare
This change reworks the packaging scripts to build inside Docker, since we can no longer build for both Ubuntu and Fedora on an Ubuntu machine.
build_packages.py
:build_packages.sh
: builds all DEB and RPM packages in Docker containersbuild_repos.sh
: builds the apt and yum repos including these packagesdebuild
andrpmbuild
directly rather than viapbuilder
andmock
build/
and this directory is added to.gitignore
HOWTO_PACKAGE.md
is updated with the new procedures to followdistro-info.sh
since it has begun developmentIn our production builds (internally), we will first run
build_packages.sh
, then sign the packages, then runbuild_repos.sh
and tar up all the build artifacts.Tested by running: