Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inclusion of deprecated nautilus extension headers. #65

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

e7appew
Copy link
Contributor

@e7appew e7appew commented Dec 8, 2018

No description provided.

@samertm
Copy link
Contributor

samertm commented Feb 14, 2019

Thanks for the patch! If you don't mind me asking, how do you know that those headers are deprecated? The docs still tell folks to import them: https://developer.gnome.org/libnautilus-extension/3.24/NautilusFileInfo.html

@e7appew
Copy link
Contributor Author

e7appew commented Feb 15, 2019

I've been compiling it on Debian unstable, which currently has version 3.30.5 of nautilus. I checked the source code of nautilus, and the headers were deprecated in version 3.27, so maybe you should hold off on the merge if you still need to support older versions. I'm not sure if there's an easy was of including the right headers with conditional compilation.

@ernestask
Copy link

I deprecated direct inclusion of those headers, this is correct. The link to the docs is for version 3.24, so, obviously, that is a poor reference to use. However, due to reasons, the online documentation is not updated for new releases, so I will need to work around that issue.

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ e7appew
❌ goffrie
You have signed the CLA already but the status is still pending? Let us recheck it.

@goffrie goffrie merged commit 66a117c into dropbox:master Nov 29, 2022
@goffrie
Copy link
Contributor

goffrie commented Nov 29, 2022

Well this is extremely delayed, but thanks for the PR 😅

❌ goffrie

silly CLA bot...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants