Stop the ticker if the script is being run without a tty. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m from). Creates messy and unusuable output.
nipunn1313
reviewed
Mar 16, 2020
| if sys.stderr.isatty(): | ||
| # Start a ticker | ||
| ticker_thread = CommandTicker() | ||
| ticker_thread.start() |
There was a problem hiding this comment.
small request to make it a little less bugprone w/ changes in the future
ticker_thread = None
if sys.stderr.isatty():
ticker_thread = CommandTicker()
ticker_thread.start()
and
if ticker_thread is not None:
ticker_thread.stop()
ticker_thread.join()
It's helpful so that any changes to the condition in the future don't have risk of a bug where it's not propagated. The full state is encoded into the ticker_thread() object directly. Thanks!
…akes in the future.
|
Updated. Completely agree with suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the ticker can create output when it is being run without a tty. This creates messy and unusuable output for scripts, emails, etc. This change is a simple suggestion of how to clean this up.