Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: handle (in some way) the new GNOME versioning scheme #98

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

DimStar77
Copy link
Contributor

@DimStar77 DimStar77 commented Feb 18, 2021

With GNOME switching from odd/even versioning for unsstable/stable
branches to 40.alpha, 40.beta, we need to trick the versioning to
our liking.

In case NAUTILUS_VERSION_MINOR contains letters, we reset it to 0.

This means we treat 40.alpha as 40.0 (as if it was the final release of the 40 series)

Fixes #97

With GNOME switching from odd/even versioning for unsstable/stable
branches to 40.alpha, 40.beta, we need to trick the versioning to
our liking.

In case NAUTILUS_VERSION_MINOR contains letters, we reset it to 0.

This means we treat 40.alpha as 40.0 (as if it was the final release of the 40 series)

Fixes issue#97
@wilbeibi
Copy link
Contributor

Thank you for submitting a PR! The change looks good.

Could you confirm you've signed the Dropbox Contributor License Agreement - https://opensource.dropbox.com/cla/ ?

@wilbeibi wilbeibi merged commit 6a9abac into dropbox:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nautilus-dropbox does not cope with GNOME 40 version schemes
2 participants